{"id":1281,"date":"2015-01-23T22:50:24","date_gmt":"2015-01-23T22:50:24","guid":{"rendered":"http:\/\/rglinuxtech.com\/?p=1281"},"modified":"2015-01-23T22:50:24","modified_gmt":"2015-01-23T22:50:24","slug":"vmware-backward-compatible-3-19-fix","status":"publish","type":"post","link":"https:\/\/rglinuxtech.com\/?p=1281","title":{"rendered":"VMware – Backward-Compatible 3.19 Fix.."},"content":{"rendered":"

After the solution to the Kernel 3.19\/vmnet problem mentioned in previous posts, I have produced a fix that includes tests for kernel versions, and works with Kernel 3.19 and<\/span> with earlier kernel versions..<\/p>\n

This is probably not the most elegant<\/em> code, but it works – I have tested it with VMware 11.0 and Kernels 3.19-rc5 and 3.18.3 (from kernel.org)..<\/p>\n

In vmnet-only\/driver.c<\/strong> – around line 267
\nchange:<\/p>\n

if (filp && filp->f_op && filp->f_op->ioctl == VNetFileOpIoctl) {<\/strong>\r\n ret = VNetFileOpIoctl(filp->f_dentry->d_inode, filp, iocmd, ioarg);<\/strong>\r\n }<\/strong>\r\n return ret;<\/strong>\r\n}<\/strong><\/pre>\n
to:<\/p>\n
#if LINUX_VERSION_CODE < KERNEL_VERSION(3, 19, 0)<\/strong>\r\n if (filp && filp->f_op && filp->f_op->ioctl == VNetFileOpIoctl) {<\/strong>\r\n ret = VNetFileOpIoctl(filp->f_dentry->d_inode, filp, iocmd, ioarg);<\/strong>\r\n }<\/strong>\r\n return ret;<\/strong>\r\n#else <\/strong>\r\n if (filp && filp->f_op && filp->f_op->ioctl == VNetFileOpIoctl) {<\/strong>\r\n ret = VNetFileOpIoctl(filp->f_path.dentry->d_inode, filp, iocmd, ioarg);<\/strong>\r\n }<\/strong>\r\n return ret;<\/strong>\r\n#endif<\/strong>\r\n}<\/strong><\/pre>\n
And, around line 1194
\nchange:<\/p>\n
if (filp && filp->f_dentry) {<\/strong>\r\n inode = filp->f_dentry->d_inode;<\/strong>\r\n }<\/strong>\r\n err = VNetFileOpIoctl(inode, filp, iocmd, ioarg);<\/strong>\r\n return err;<\/strong><\/pre>\n
to:<\/p>\n
#if LINUX_VERSION_CODE < KERNEL_VERSION(3, 19, 0)<\/strong>\r\n if (filp && filp->f_dentry) {<\/strong>\r\n inode = filp->f_dentry->d_inode;<\/strong>\r\n }<\/strong>\r\n err = VNetFileOpIoctl(inode, filp, iocmd, ioarg);<\/strong>\r\n return err;<\/strong>\r\n#else <\/strong>\r\n if (filp && filp->f_path.dentry) {<\/strong>\r\n inode = filp->f_path.dentry->d_inode;<\/strong>\r\n }<\/strong>\r\n err = VNetFileOpIoctl(inode, filp, iocmd, ioarg);<\/strong>\r\n return err;<\/strong>\r\n#endif<\/strong><\/pre>\n
In vmnet-only\/userif.c<\/strong> – around line 526
\nchange:<\/p>\n
return skb_copy_datagram_iovec(skb, 0, &iov, len);<\/strong><\/pre>\n
to:<\/p>\n
#if LINUX_VERSION_CODE < KERNEL_VERSION(3, 19, 0)<\/strong>\r\n return skb_copy_datagram_iovec(skb, 0, &iov, len);<\/strong>\r\n#else<\/strong>\r\n struct iov_iter to;<\/strong>\r\n iov_iter_init(&to, READ, &iov, 1, len);<\/strong>\r\n return skb_copy_datagram_iter(skb, 0, &to, len);<\/strong>\r\n#endif<\/strong><\/pre>\n
Basically, test for kernel version prior to 3.19, and if found, use the ‘old’ code, otherwise, use the ‘new’ code..<\/p>\n
Once again, thanks are due to Al Viro and coderus<\/strong><\/em> for the fix for skb_copy_datagram_iovec<\/em>..<\/p>\n
Hopefully this makes sense!<\/p>\n
Robert Gadsdon\u00a0\u00a0 January 23, 2015.<\/em><\/p>\n","protected":false},"excerpt":{"rendered":"
After the solution to the Kernel 3.19\/vmnet problem mentioned in previous posts, I have produced a fix that includes tests for kernel versions, and works with Kernel 3.19 and with earlier kernel versions.. This is probably not the most elegant code, but it works – I have tested it with VMware 11.0 and Kernels 3.19-rc5 and 3.18.3 …<\/span> Continue reading →<\/span><\/a><\/p>\n","protected":false},"author":1,"featured_media":0,"comment_status":"open","ping_status":"closed","sticky":false,"template":"","format":"standard","meta":{"_monsterinsights_skip_tracking":false,"_monsterinsights_sitenote_active":false,"_monsterinsights_sitenote_note":"","_monsterinsights_sitenote_category":0,"footnotes":""},"categories":[5,6,11,14,15,19,20,25],"tags":[991,990,1175,992,761,957],"class_list":["post-1281","post","type-post","status-publish","format-standard","hentry","category-compilation","category-crash-and-burn","category-hacks","category-kernel","category-linux-2","category-opinion","category-performance-2","category-vmware","tag-backward-compatible","tag-kernel-3-19-fix","tag-success","tag-test-for-kernel-version","tag-vmnet","tag-vmware-11"],"_links":{"self":[{"href":"https:\/\/rglinuxtech.com\/index.php?rest_route=\/wp\/v2\/posts\/1281","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/rglinuxtech.com\/index.php?rest_route=\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/rglinuxtech.com\/index.php?rest_route=\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/rglinuxtech.com\/index.php?rest_route=\/wp\/v2\/users\/1"}],"replies":[{"embeddable":true,"href":"https:\/\/rglinuxtech.com\/index.php?rest_route=%2Fwp%2Fv2%2Fcomments&post=1281"}],"version-history":[{"count":1,"href":"https:\/\/rglinuxtech.com\/index.php?rest_route=\/wp\/v2\/posts\/1281\/revisions"}],"predecessor-version":[{"id":1282,"href":"https:\/\/rglinuxtech.com\/index.php?rest_route=\/wp\/v2\/posts\/1281\/revisions\/1282"}],"wp:attachment":[{"href":"https:\/\/rglinuxtech.com\/index.php?rest_route=%2Fwp%2Fv2%2Fmedia&parent=1281"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/rglinuxtech.com\/index.php?rest_route=%2Fwp%2Fv2%2Fcategories&post=1281"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/rglinuxtech.com\/index.php?rest_route=%2Fwp%2Fv2%2Ftags&post=1281"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}